Issue #222: update to CS 8.21 #223
Merged
+62
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
muhlba91
commented
Jun 3, 2019
muhlba91
commented
- fixes upgrade to checkstyle 8.21 #222
- only check for presence of non-deprecated properties on checks
rnveach
approved these changes
Jun 3, 2019
|
I am surprised that I do not see my comment about testing artifacts .... @muhlba91 , please provide some testing artifacts/screenshots/logs to prove that you tested upgrade and new Check is executing without problems ..... and we can make a release. |
|
@romani sorry, your message got lost due to mail server failure in the company and, hence, me not receiving the email notification for your comment. Please see screenshot of the check running through. :) FYI, I realized that I have set the default scope to private and not public -> fixed now. |
|
@muhlba91 , ping. |
romani
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.